Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough계정 응답 DTO와 조회 서비스를 추가하고, JWT 기반 Changes계정 정보 조회
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant AccountController
participant AccountService
participant UserRepository
participant NotificationSettingRepository
Client->>AccountController: GET /api/settings/account with JWT
AccountController->>AccountService: getAccount(userId)
AccountService->>UserRepository: findById(userId)
AccountService->>NotificationSettingRepository: findByUser(user)
AccountService-->>AccountController: AccountResponse
AccountController-->>Client: ApiResponse success
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/test/java/com/leets7th/job_is_be/domain/user/service/AccountServiceTest.java`:
- Around line 53-63: 정상 조회 테스트에서 User fixture의 createdAt을 고정된 값으로 설정하고,
accountService.getAccount(1L) 결과에 대해 response.joinedAt()이 해당 값과 일치하는지 검증하세요. 기존
socialType, receivingEmail, emailVerified 검증은 유지하세요.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d13301f9-0bf7-4233-8350-1c6ee0796f0d
📒 Files selected for processing (5)
src/main/java/com/leets7th/job_is_be/domain/user/controller/AccountController.javasrc/main/java/com/leets7th/job_is_be/domain/user/dto/AccountResponse.javasrc/main/java/com/leets7th/job_is_be/domain/user/service/AccountService.javasrc/main/java/com/leets7th/job_is_be/global/status/SuccessStatus.javasrc/test/java/com/leets7th/job_is_be/domain/user/service/AccountServiceTest.java
1 participant
#️⃣ 관련 이슈
closed #39
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
🧩 작업 내용
계정 정보 조회 API 구현했습니다.
GET /api/settings/account— 소셜 연결, 가입일, 수신 이메일, 이메일 확인 상태 조회주요 구현 내용
socialType(카카오/구글 provider만 노출, 소셜 고유 ID는 노출하지 않음),joinedAt(가입일),receivingEmail,emailVerifiedemailVerified는NotificationSetting엔티티 값을 가져오는데, 유저가 알림 설정을 한 번도 안 건드려서 해당 row가 없으면false로 반환 (이 조회 API 때문에 다른 도메인 row를 새로 만들지는 않도록 처리)AccountServiceTest): 사용자 없음 / 정상 조회 / 알림 설정 미생성 시 미확인 처리📸 스크린샷(선택)
📣 To Reviewers
socialType만 노출하고socialId는 응답에 포함하지 않았는데, 와이어프레임(SET-02) 기준으로는 이거면 충분해 보입니다. 혹시 프론트에서 더 필요한 필드 있으면 말씀해주세요.Summary by CodeRabbit
새 기능
버그 수정
테스트